Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connector): make source connector's metrics guarded #17593

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Jul 7, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #17529

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@lmatz lmatz requested a review from tabVersion July 8, 2024 04:51
@lmatz lmatz added this pull request to the merge queue Jul 8, 2024
Merged via the queue into main with commit f377020 Jul 8, 2024
30 of 31 checks passed
@lmatz lmatz deleted the lz/source_metrics branch July 8, 2024 07:09
@fuyufjh
Copy link
Member

fuyufjh commented Sep 6, 2024

I observed a wired curve online as following

image

It's probably caused by the usage of Guarded metrics in this PR, which is incorrect.

"Guarded" means that when drop() is called, it removes the label from the Prometheus client.

This PR changes with_label_values to with_guarded_label_values, which results in the metrics being reported once and then immediately dropped.

The correct approach is to place GuardedMetrics in a location where its lifecycle matches that of the object associated with the metrics (for example, placing the metrics of a Source in the SourceExecutor or an internal struct within it). This way, when the SourceExecutor is dropped, the metrics are also dropped simultaneously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

source metrics are not label guarded and will not be dropped
3 participants