Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(storage): allow dynamic enable/disable minitrace for tiered cache #17570

Merged
merged 5 commits into from
Jul 4, 2024

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Jul 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Introduce new RPC to dynamically enable/disable and configure minitrace for tiered cache.

The RPC can be sent from risectl.

Usage:

Usage: risingwave ctl hummock tiered-cache-tracing [OPTIONS]

Options:
      --enable                                                                 
      --record-hybrid-insert-threshold-ms <RECORD_HYBRID_INSERT_THRESHOLD_MS>  
      --record-hybrid-get-threshold-ms <RECORD_HYBRID_GET_THRESHOLD_MS>        
      --record-hybrid-obtain-threshold-ms <RECORD_HYBRID_OBTAIN_THRESHOLD_MS>  
      --record-hybrid-remove-threshold-ms <RECORD_HYBRID_REMOVE_THRESHOLD_MS>  
      --record-hybrid-fetch-threshold-ms <RECORD_HYBRID_FETCH_THRESHOLD_MS>    
  -h, --help                                                                   Print help
  -V, --version                                                                Print version

An #17433 alternative.

image

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@MrCroxx MrCroxx requested a review from a team as a code owner July 4, 2024 07:25
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

@MrCroxx MrCroxx requested a review from BugenZhao July 4, 2024 08:17
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runtime part LGTM

@@ -492,6 +510,18 @@ pub fn init_risingwave_logger(settings: LoggerSettings) {
.with_filter(reload_filter);

layers.push(layer.boxed());

let reporter = OpenTelemetryReporter::new(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May leave some comments showing that minitraces cannot be triggered by enable_tracing layer, but are controlled by foyer-related RPC.

@MrCroxx MrCroxx enabled auto-merge July 4, 2024 10:50
@MrCroxx MrCroxx added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 7159f9a Jul 4, 2024
31 of 32 checks passed
@MrCroxx MrCroxx deleted the xx/ctltracing branch July 4, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants