Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add serde and serde_json v1 with derive to Cargo.toml in SQL migration #17564

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

shanicky
Copy link
Contributor

@shanicky shanicky commented Jul 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Used to ensure clean dependencies in the pull request #17523

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

@shanicky shanicky requested a review from yezizp2012 July 4, 2024 06:20
@shanicky shanicky requested a review from a team as a code owner July 4, 2024 06:20
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please include more details about your motivation.

@shanicky shanicky enabled auto-merge July 4, 2024 06:34
@shanicky shanicky added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 3e7418c Jul 4, 2024
32 of 33 checks passed
@shanicky shanicky deleted the peng/add-dep-to-migration branch July 4, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants