fix(frontend): fix changelog out_col_change error and add snowflake upsert sink demo #17515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxhZs
force-pushed
the
xxh/snowflake-upsert-demo
branch
from
37c05a6 to
0522b2b
Compare
hzxa21
reviewed
Jul 1, 2024
Comment on lines
81
to
86
| let out_col_change = if self.base.stream_key().is_none() { | ||
| ColIndexMapping::new(output_vec, len + 1) | ||
| } else { | ||
| (changelog, input_col_change) | ||
| } | ||
| output_vec.push(Some(len)); | ||
| ColIndexMapping::new(output_vec, len + 1) | ||
| }; |
There was a problem hiding this comment.
I don't get this logic, probably because I am not familiar with the optimzier codes. But it seems that we are relying on some implicit assumption here. Can you elaborate more?
- Why do we need to extend the
ColIndexMappingwithout extendingoutput_vecwhen the stream key is none? - When will the stream key be none?
There was a problem hiding this comment.
stream_key.is_none means that _changelog_row_id is not included in the select result. This has been changed to need_changelog_row_id to make the logic clearer.
When the results does not contain _changelog_row_id , _changelog_row_id is the hidden column added by this operator, and the ColIndexMapping should be null->index (here is len)
chenzl25
reviewed
Jul 2, 2024
9 tasks
tabVersion
pushed a commit
that referenced
this pull request
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Forgot to add _changelog_row_id records in out_col_change , this is an error.
Added demo that implements snowflake upsert sink using changelog
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
Need to add the demo to the documentation