Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(telemetry): support report event to telemetry #17486
feat(telemetry): support report event to telemetry #17486
Changes from 4 commits
e69b492
9fe1104
fd3c448
d09b6fb
33a2699
c9e588a
fb3aa40
21c029e
d054295
9aa4ae2
f40bb11
3a16391
15c9cd4
34756e8
d1247b6
833ca62
6af6559
daf62d3
981e797
b88c1dd
ace85e0
ca7dbe8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we name it "event_name"? The examples in this PR are
normal_recovery
,adhoc_recovery
,failure_recovery
etc. which doesn't seem to be "feature" to me.Besides,
&str
seems better, because it implies the event name must be a static string, and dynamic values should be put inattributes
.