Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): decouple upload task finish order from epoch #17460

Merged
merged 30 commits into from
Jul 9, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Jun 26, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

After #17500

Currently, spill task and syncing task are organized in the order of epoch. However, when we support partial checkpoint, the epoch of different spill task and syncing task should be decoupled. Therefore, in this PR, we refactor the uploader so that the task finish order won't be based on epoch.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Base automatically changed from yiming/remove-sync-finish-event to main June 26, 2024 06:30
@wenym1 wenym1 marked this pull request as ready for review June 26, 2024 10:13
@wenym1 wenym1 changed the base branch from main to yiming/uploader-no-global-epoch June 28, 2024 10:32
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments. LGTM.

src/storage/src/hummock/event_handler/uploader/mod.rs Outdated Show resolved Hide resolved
src/storage/src/hummock/event_handler/uploader/mod.rs Outdated Show resolved Hide resolved
src/storage/src/hummock/event_handler/uploader/mod.rs Outdated Show resolved Hide resolved
src/storage/src/hummock/event_handler/uploader/mod.rs Outdated Show resolved Hide resolved
src/storage/src/hummock/event_handler/uploader/mod.rs Outdated Show resolved Hide resolved
@wenym1 wenym1 force-pushed the yiming/dag-uploader branch from b7fc02a to abf2ff8 Compare July 9, 2024 06:29
Base automatically changed from yiming/uploader-no-global-epoch to main July 9, 2024 08:10
@wenym1 wenym1 added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit b9ceb8d Jul 9, 2024
29 of 30 checks passed
@wenym1 wenym1 deleted the yiming/dag-uploader branch July 9, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants