Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: workaround include_key_as flaky test #17457

Merged
merged 3 commits into from
Jun 26, 2024
Merged

test: workaround include_key_as flaky test #17457

merged 3 commits into from
Jun 26, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jun 26, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Root cause is #17448, which needs a more careful fix.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan requested review from tabVersion and BugenZhao June 26, 2024 02:14
@xxchan xxchan enabled auto-merge June 26, 2024 02:14
@github-actions github-actions bot added the component/test Test related issue. label Jun 26, 2024
@xxchan xxchan added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 0830f4f Jun 26, 2024
29 of 30 checks passed
@xxchan xxchan deleted the xxchan/outdoor-gayal branch June 26, 2024 04:02
shanicky pushed a commit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants