Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "cherry-pick feat upgrade to opendal 0.47 in object store (#17198) (#17327)" #17444

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented Jun 25, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

I think it is better not block 1.10 release while we are investigating the opendal 0.47 issue causing #17432. This PR reverts #17327 and pin the reqsign commit according to #17442 to make sure azure identity resolution can work in release 1.10.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@hzxa21 hzxa21 requested review from lmatz, huangjw806 and wcy-fdu June 25, 2024 07:28
@hzxa21 hzxa21 requested a review from a team as a code owner June 25, 2024 07:28
@hzxa21 hzxa21 added this pull request to the merge queue Jun 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 25, 2024
@hzxa21 hzxa21 added this pull request to the merge queue Jun 25, 2024
Merged via the queue into release-1.10 with commit 18effe1 Jun 25, 2024
27 of 28 checks passed
@hzxa21 hzxa21 deleted the patrick/revert-1.10-opendal-0.47 branch June 25, 2024 10:10
hzxa21 added a commit that referenced this pull request Jun 26, 2024
hzxa21 added a commit that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants