test: add data-driven Avro decode integration tests #17434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
xxchan
changed the title
xxchan
force-pushed
the
06-20-test_add_codec_integration_tests
branch
from
f2caca4 to
5f37c9b
Compare
xxchan
changed the title
xxchan
force-pushed
the
06-20-test_add_codec_integration_tests
branch
from
5f37c9b to
291f561
Compare
xxchan
commented
Jun 25, 2024
| let record = build_avro_data(conf.schema.original_schema.as_ref()); | ||
| writer.append(record).unwrap(); | ||
| let encoded = writer.into_inner().unwrap(); | ||
| println!("path = {:?}", e2e_file_path("avro_simple_schema_bin.1")); |
There was a problem hiding this comment.
There're still some usage of this data file to be cleaned.
12 tasks
xxchan
force-pushed
the
06-20-test_add_codec_integration_tests
branch
3 times, most recently
from
9f3b8fc to
3222903
Compare
fuyufjh
reviewed
Jul 3, 2024
There was a problem hiding this comment.
LGTM, but I didn't really get the motivation. Perhaps @xiangjinwu knows better 😄
Comment on lines
-455
to
-456
| async fn test_avro_union_type() { | ||
| let parser = new_avro_parser_from_local("union-schema.avsc") |
There was a problem hiding this comment.
Why this case is not in the new tests?
There was a problem hiding this comment.
You are right. It seems to be missed.
xxchan
force-pushed
the
06-20-test_add_codec_integration_tests
branch
from
3222903 to
2351718
Compare
xiangjinwu
approved these changes
Jul 5, 2024
Comment on lines
31
to
33
| if !f.alternate() || s.len() == 1 { | ||
| let (name, ty) = s.iter().next().unwrap(); | ||
| return write!(f, "Struct {{ {}: {:?} }}", name, &DataTypeTestDisplay(ty)); |
There was a problem hiding this comment.
Why do we only display the first field of a struct when !f.alternate()?
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
xxchan
force-pushed
the
06-20-test_add_codec_integration_tests
branch
from
2351718 to
de77653
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Background:
This PR proposes to improve the tests with 2 ideas:
Do unit/integration test for encodings.
Logically, these features have a nice clear boundary, there's no reason to start a cluster and write verbose e2e test for them, except we don't have a clear boundary in code. But we are improving the code organization during refactor: split source parser into separate crate #17002, and the test boundary can also be improved now.
Data-driven tests.
Like planner test, execution integration test... We just write input data (instead of using code to generate data). The result can be generated, and displayed in nice human readable format.
Benefits:
UPDATE_EXPECT=1 cargo test -p risingwave_connector_codec, or use Rust Analyzer toRun test + expectLimitations:
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.