Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mysql-cdc): fix auto schema mapping #17402

Merged
merged 8 commits into from
Jun 23, 2024
Merged

Conversation

StrikeW
Copy link
Contributor

@StrikeW StrikeW commented Jun 22, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously we didn't init the upstream MySQL version to the SchemaDiscovery, so when it query the information_schema.statistics, it would not select the expression column.
The documentation and example of sea-schema doesn't reveal this details.

This PR reimplement the auto schema discovery of mysql-cdc, which only discover columns and would not discover indexes and foreign keys.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@StrikeW StrikeW added the need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged label Jun 22, 2024
@github-actions github-actions bot added the type/fix Bug fix label Jun 22, 2024
@StrikeW StrikeW force-pushed the siyuan/fix-mysql-auto-schema branch from 0a09b29 to 9f408e5 Compare June 23, 2024 05:21
@StrikeW StrikeW force-pushed the siyuan/fix-mysql-auto-schema branch from 7ddde7e to 5aff458 Compare June 23, 2024 08:30
@StrikeW StrikeW requested review from lmatz and fuyufjh June 23, 2024 09:11
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a pitfall! Thanks!

@StrikeW StrikeW added this pull request to the merge queue Jun 23, 2024
Merged via the queue into main with commit 57798fa Jun 23, 2024
29 of 30 checks passed
@StrikeW StrikeW deleted the siyuan/fix-mysql-auto-schema branch June 23, 2024 12:53
github-actions bot pushed a commit that referenced this pull request Jun 23, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants