-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mysql-cdc): fix auto schema mapping #17402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikeW
added
the
need-cherry-pick-release-1.10
Open a cherry-pick PR to branch release-1.10 after the current PR is merged
label
Jun 22, 2024
StrikeW
force-pushed
the
siyuan/fix-mysql-auto-schema
branch
from
June 23, 2024 05:21
0a09b29
to
9f408e5
Compare
StrikeW
added
ci/run-build
ci/run-build-other
ci/run-e2e-source-tests
and removed
ci/run-build
ci/run-build-other
ci/run-e2e-source-tests
labels
Jun 23, 2024
StrikeW
force-pushed
the
siyuan/fix-mysql-auto-schema
branch
from
June 23, 2024 08:30
7ddde7e
to
5aff458
Compare
lmatz
approved these changes
Jun 23, 2024
fuyufjh
approved these changes
Jun 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such a pitfall! Thanks!
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 23, 2024
Co-authored-by: StrikeW <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
need-cherry-pick-release-1.10
Open a cherry-pick PR to branch release-1.10 after the current PR is merged
type/fix
Bug fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously we didn't init the upstream MySQL version to the
SchemaDiscovery
, so when it query theinformation_schema.statistics
, it would not select theexpression
column.The documentation and example of sea-schema doesn't reveal this details.
This PR reimplement the auto schema discovery of mysql-cdc, which only discover columns and would not discover indexes and foreign keys.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.