Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sqlparser): allow rhs of AT TIME ZONE to be non-literal #17395

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

xiangjinwu
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Before: t.local AT TIME ZONE 'US/Pacific'
After: t.local AT TIME ZONE t.zone

Resolves #17384

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

The time zone parameter of AT TIME ZONE is no longer limited to literals and can be arbitrary varchar expression.

@xiangjinwu xiangjinwu added need-cherry-pick-release-1.9 need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged labels Jun 21, 2024
@xiangjinwu xiangjinwu added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit 70eb3d0 Jun 21, 2024
38 of 39 checks passed
@xiangjinwu xiangjinwu deleted the feat-sqlparser-at-time-zone-expr branch June 21, 2024 10:44
github-merge-queue bot pushed a commit that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(sqlparser): allow rhs of AT TIME ZONE to any expr in addition to literal
2 participants