Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sink): add config
auto_create
for BigQuery #17393feat(sink): add config
auto_create
for BigQuery #17393Changes from 4 commits
d766ed1
27fbb6f
de1f75c
72b4250
4bd4183
bbdc227
67ef95f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be supported, If it is not possible, please also set what is written below as not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should indeed be unsupported for now: https://cloud.google.com/bigquery/docs/schemas#standard_sql_data_types. (no
interval
here, in pre-ga)What needs to be added in the error message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it before and it works, you can retest it, if it doesn't work, please disable
interval
in the code elsewheredoc is in https://cloud.google.com/bigquery/docs/write-api?hl=zh-cn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does support it, but it is not a stable feature yet.
In addition, the sdk FieldType have no
Interval
. It's used to constructTable
that table().create() would use.I think we can let it keep the unsupported error? Panic when validate failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to change it in
get_string_and_check_support_from_datatype
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About
Interval
?Unlike the case of
map_field
, which is used to create a BigQuery table, we can avoid actively using unstable typeInterval
; the return value ofget_string_and_check_support_from_datatype
is used to validate types of BigQuery table columns. If a column is indeed anInterval
type, I don't think we have any reason to refuse?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks for the explanation. Would you mind adding the explanations here into the code comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When auto_create_table=true, it seems that there is no need to query the schema again