feat(telemetry): collect deploy mode in telemetry #17392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Jun 21, 2024
proto/telemetry.proto
Outdated
| TELEMETRY_CLUSTER_TYPE_SINGLE_NODE = 1; | ||
| TELEMETRY_CLUSTER_TYPE_TEST = 2; | ||
| TELEMETRY_CLUSTER_TYPE_DOCKER_COMPOSE = 3; | ||
| TELEMETRY_CLUSTER_TYPE_KUBERNETES = 4; |
There was a problem hiding this comment.
I think we should differentiate kubernetes deployments with cloud deployments.
There was a problem hiding this comment.
Cloud use TELEMETRY_CLUSTER_TYPE_HOSTED, setting by @arkbriar
see
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
tabVersion
added
the
need-cherry-pick-release-1.10
neverchanje
reviewed
Jun 24, 2024
Signed-off-by: tabVersion <[email protected]>
fuyufjh
reviewed
Jun 24, 2024
proto/telemetry.proto
Outdated
Comment on lines
24
to
30
| TELEMETRY_CLUSTER_TYPE_UNSPECIFIED = 0; | ||
| TELEMETRY_CLUSTER_TYPE_SINGLE_NODE = 1; | ||
| TELEMETRY_CLUSTER_TYPE_TEST = 2; | ||
| TELEMETRY_CLUSTER_TYPE_DOCKER_COMPOSE = 3; | ||
| TELEMETRY_CLUSTER_TYPE_KUBERNETES = 4; | ||
| TELEMETRY_CLUSTER_TYPE_HOSTED = 5; | ||
| TELEMETRY_CLUSTER_TYPE_STANDALONE = 6; |
There was a problem hiding this comment.
These concepts are not orthogonal. For example, the CI/CD pipeline may run tests in standalone mode, making it confusing to different people.
I tend to use 2 separated dimensions
- Is it a test or development instance? If yes, should be excluded from telemetry. I think our existing
TELEMETRY_ENABLEDis enough for this usage. - If it's a production cluster, how it is deployed? e.g. docker-compose, Kubernetes or standalone.
There was a problem hiding this comment.
Make sense, let's make the TELEMETRY_ENABLED default to true.
fuyufjh
reviewed
Jun 24, 2024
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
|
aligned behavior:
|
fuyufjh
reviewed
Jun 24, 2024
Signed-off-by: tabVersion <[email protected]>
fuyufjh
approved these changes
Jun 28, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
Signed-off-by: tabVersion <[email protected]> Co-authored-by: tabVersion <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
Signed-off-by: tabVersion <[email protected]> Co-authored-by: Bohan Zhang <[email protected]> Co-authored-by: tabVersion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.