feat(cdc): support alter cdc table schema #17334
Merged
Task list completed / task-list-completed
Started
2024-07-07 10:00:56
ago
2 / 8 tasks completed
6 tasks still to be completed
Details
Required Tasks
| Task | Status |
|---|---|
| I have written necessary rustdoc comments | Completed |
| I have added necessary unit tests and integration tests | Completed |
| I have added test labels as necessary. See details. | Incomplete |
| I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934). | Incomplete |
| My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future). | Incomplete |
All checks passed in ./risedev check (or alias, ./risedev c) |
Incomplete |
| My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details) | Incomplete |
| My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users) | Incomplete |
| Understand the implications of revoking this secret by investigating where it is used in your code. | Incomplete |
| Replace and store your secrets safely. Learn here the best practices. | Incomplete |
| Revoke and rotate these secrets. | Incomplete |
| If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. | Incomplete |
| following these best practices for managing and storing secrets including API keys and other credentials | Incomplete |
| install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation. | Incomplete |
I remember that we had a discussion long ago (#9828) that we should purify the definition of a table/source before persisting it into the catalog. In this case, for example, * is completely a syntax-sugar and should be first expanded to column definitions. cc @st1page |
Incomplete |
Considering empty columns as created with * is also a fragile assumption. Users are allowed to create a table without columns like CREATE TABLE t;. |
Incomplete |
w/o -u root, it will use current user $USER to login which cannot work in my local env. |
Incomplete |
w/o --protocol='tcp', it cannot connect to the mysql container from host in my local env. |
Incomplete |
You don't need to manually set MYSQL_ env vars manually. |
Incomplete |
| When you change the configs, the env vars are also updated automatically. | Incomplete |
Loading