Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(diagnosis): improve barrier manager display #17317

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Jun 18, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolves #17295

Preview:

[BarrierWorkerState (Worker 2)]
running_actors: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 
actor_to_send: 17, 18, 19, 20, 
creating_actors:
has_control_stream_connected: true
managed_barrier_state:
> Epoch 6649908152762368 (Checkpoint): Issued. Remaining actors: [3, ]
> Epoch 6649908218298368 (Checkpoint): Issued. Remaining actors: [1, 2, 4, ...and 1 actors in prev epoch]
> Epoch 6649908283768832 (Checkpoint): Issued. Remaining actors: [5, 6, 7, 8, 9, 10, 11, 12, ...and 4 actors in prev epoch]
> Epoch 6649908349304832 (Checkpoint): Issued. Remaining actors: [...and 12 actors in prev epoch]
> Epoch 6649908414906368 (Checkpoint): Issued. Remaining actors: [13, 14, 15, 16, 17, 18, 19, 20, ...and 12 actors in prev epoch]

Preview with AllCollected:

managed_barrier_state:
> Epoch 6649908021624832 (Checkpoint): AllCollected
> Epoch 6649908087160832 (Checkpoint): Issued. Remaining actors: [1, 2, 3, 4, ]
> Epoch 6649908152762368 (Checkpoint): Issued. Remaining actors: [5, 6, 7, 8, ...and 4 actors in prev epoch]

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@fuyufjh fuyufjh requested review from BugenZhao and wenym1 June 18, 2024 10:04
@fuyufjh fuyufjh changed the title Eric/better local barrier mgr trace display feat(diagnosis): improve barrier manager display Jun 18, 2024
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuyufjh fuyufjh enabled auto-merge June 21, 2024 03:20
@fuyufjh fuyufjh added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit fcfa573 Jun 21, 2024
29 of 30 checks passed
@fuyufjh fuyufjh deleted the eric/better_local_barrier_mgr_trace_display branch June 21, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

barrier manager state is too verbose in await-tree dump
3 participants