-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meta): compress the encoded model if it's too large in kv meta store #17315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tore Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/compress-kv-meta-model
branch
from
June 18, 2024 09:29
db892e9
to
f18f21d
Compare
yezizp2012
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Thx for the PR.
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/compress-kv-meta-model
branch
from
June 18, 2024 09:42
f18f21d
to
e03ad32
Compare
xxchan
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lock
BugenZhao
added
the
ci/run-backwards-compat-tests
Run backwards compatibility tests in your PR.
label
Jun 19, 2024
kwannoel
pushed a commit
that referenced
this pull request
Aug 14, 2024
…tore (#17315) Signed-off-by: Bugen Zhao <[email protected]>
kwannoel
pushed a commit
that referenced
this pull request
Aug 15, 2024
…tore (#17315) Signed-off-by: Bugen Zhao <[email protected]>
9 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
…store (#17315) (#18050) Signed-off-by: Bugen Zhao <[email protected]> Co-authored-by: Bugen Zhao <[email protected]>
kwannoel
pushed a commit
that referenced
this pull request
Aug 20, 2024
…tore (#17315) Signed-off-by: Bugen Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/run-backwards-compat-tests
Run backwards compatibility tests in your PR.
ci/run-e2e-single-node-tests
type/feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Implement the idea in #11072 (comment), as a quick hack to reduce the possibility of exceeding the max request size.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.