Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): compress the encoded model if it's too large in kv meta store #17315

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Implement the idea in #11072 (comment), as a quick hack to reduce the possibility of exceeding the max request size.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thx for the PR.

Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao force-pushed the bz/compress-kv-meta-model branch from f18f21d to e03ad32 Compare June 18, 2024 09:42
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lock

@BugenZhao BugenZhao added the ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. label Jun 19, 2024
@BugenZhao BugenZhao added this pull request to the merge queue Jun 19, 2024
Merged via the queue into main with commit 3fdb12e Jun 19, 2024
35 of 36 checks passed
@BugenZhao BugenZhao deleted the bz/compress-kv-meta-model branch June 19, 2024 09:48
kwannoel pushed a commit that referenced this pull request Aug 14, 2024
kwannoel pushed a commit that referenced this pull request Aug 15, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 15, 2024
kwannoel pushed a commit that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants