Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): introduce file sink in PARQUET format #17311

Merged
merged 86 commits into from
Aug 22, 2024

revert box in FileSink struct

807c869
Select commit
Loading
Failed to load commit list.
Merged

feat(sink): introduce file sink in PARQUET format #17311

revert box in FileSink struct
807c869
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks skipped Aug 21, 2024 in 2s

You tagged this GitGuardian alert as a false positive

1 secret were uncovered from the scan of 86 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #17311: wcy/s3_sink 👉 main
GitGuardian id GitGuardian status Secret Commit Filename
9425213 Triggered Generic Password b8b7479 ci/scripts/e2e-sink-test.sh View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.