fix(secret): add a secret ref column to source

[yuhao-su]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

We had a secret_ref for source in StreamSourceInfo, but it should be used for format/encode option. We need another secret_ref for source.

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• I have added test labels as necessary. See details.
• I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
• My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
• All checks passed in ./risedev check (or alias, ./risedev c)
• My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

• My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

• My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

We had a secret_ref for source in StreamSourceInfo, but it should be used for format/encode option. We need another secret_ref for source.

Add this to avoid backward compatibility issue

[tabVersion]

you should not modify an existing migration, just create a new one

[yuhao-su]

@yezizp2012 said it's ok since it's not released

[yuhao-su]

There are more to change. secret_ref should not be map<string, u32>. We need more than a secret id like if it's an as file

[tabVersion]

There are more to change. secret_ref should not be map<string, u32>.

Here is a little diff with my assumption, ref secret <secret-name> means the source/sink relies on the secret binary. Seeing it as a string, or a file, is something more related to the exec itself rather than spec in catalog.
Just share my thoughts, it is okay you impl in your way.

[tabVersion]

We had a secret_ref for source in StreamSourceInfo, but it should be used for format/encode option. We need another secret_ref for source.

Then let's unify them at the source level, pb source carries all secret mapping.

[yuhao-su]

Then let's unify them at the source level, pb source carries all secret mapping.

How do you tell the difference between secrets for source and encode/format when they have the same name.

[yuhao-su]

Any way, I guess a migration script might be a better solution for those problem.

[yezizp2012]

LGTM, need to ensure that it will be included in release 1.10.