Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): deserialize output columns only #17260

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Jun 14, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Deserialize only the required column in StorageTable's get and iter.
  • Fix a bug in ColumnAwareSerde::new when calculating column_with_default.

Find more details in
##16763 (comment)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@zwang28 zwang28 requested review from hzxa21 and BugenZhao June 14, 2024 07:54
@zwang28 zwang28 requested a review from st1page June 14, 2024 07:56
@zwang28 zwang28 requested a review from BugenZhao June 17, 2024 03:53
@zwang28 zwang28 requested a review from hzxa21 June 17, 2024 06:46
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BugenZhao PTAL

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Surprised to find we didn't do this before.

src/storage/src/table/batch_table/storage_table.rs Outdated Show resolved Hide resolved
src/storage/src/table/batch_table/storage_table.rs Outdated Show resolved Hide resolved
@zwang28 zwang28 force-pushed the wangzheng/deserialize_partial_row branch from 9ad40ba to 8f3d37d Compare June 18, 2024 05:36
@zwang28 zwang28 enabled auto-merge June 18, 2024 05:47
@zwang28 zwang28 added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit ade66c7 Jun 18, 2024
29 of 30 checks passed
@zwang28 zwang28 deleted the wangzheng/deserialize_partial_row branch June 18, 2024 06:26
zwang28 added a commit that referenced this pull request Jul 4, 2024
zwang28 added a commit that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants