Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrocs): fix hybrid cache hit ratio by upgrading foyer #17251

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Jun 14, 2024

Signed-off-by: MrCroxx [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title.

Related PR in foyer: foyer-rs/foyer#560

foyer change log: https://github.com/MrCroxx/foyer/blob/main/CHANGELOG.md

details:

crate version
foyer 0.9.4
foyer-storage 0.8.5
foyer-bench 0.1.4
  • Fix phantom entries after foyer storage recovery. #560
  • Fix hybrid cache hit metrics with fetch() interface. #563

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@MrCroxx MrCroxx self-assigned this Jun 14, 2024
@MrCroxx MrCroxx requested a review from a team as a code owner June 14, 2024 04:06
@github-actions github-actions bot added the type/fix Bug fix label Jun 14, 2024
@MrCroxx MrCroxx requested review from hzxa21 and Li0k June 14, 2024 04:06
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would you mind including the foyer PR as well in the PR description?

@MrCroxx MrCroxx enabled auto-merge June 14, 2024 04:09
@MrCroxx MrCroxx added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit c02359b Jun 14, 2024
33 of 34 checks passed
@MrCroxx MrCroxx deleted the xx/foyer branch June 14, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants