fix(jdbc-sink): set network timeout #17244
Conversation
BugenZhao
added
the
user-facing-changes
| // default timeout in seconds | ||
| final int CONNECTION_TIMEOUT = 30; | ||
| final int SOCKET_TIMEOUT = 300; |
There was a problem hiding this comment.
Shall we further allow users to configure this?
There was a problem hiding this comment.
We can add new WITH option to allow customize the configs.
| // postgres use seconds and mysql use milliseconds | ||
| int connectTimeout = isPg ? CONNECTION_TIMEOUT : CONNECTION_TIMEOUT * 1000; | ||
| int socketTimeout = isPg ? SOCKET_TIMEOUT : SOCKET_TIMEOUT * 1000; | ||
| props.setProperty("connectTimeout", String.valueOf(connectTimeout)); |
There was a problem hiding this comment.
Instead of passing the value via props, I think we can create the connection with only jdbcUrl anyway and then get and reset the timeout by the methods provided in the Connection
https://docs.oracle.com/javase%2F8%2Fdocs%2Fapi%2F%2F/java/sql/Connection.html
It provides get/setNetworkTimeout method in the interface.
There was a problem hiding this comment.
setNetworkTimeout(Executor executor, int milliseconds)
I inspected the interface. But the first arg is confusing. For PG we can pass null for the executor, but for MySQL it will throw an exception if first arg is null.
These properties are well documented in the driver's doc, so this way should be reliable to set the timeout.
Co-authored-by: StrikeW <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Set
connectTimeoutandsocketTimeoutfor the JDBC connection.If timeout occurred, the connection become invalid and will recreate a new connection.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.