Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): reduce overhead of merge_barrier_alignment_duration #17222

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Jun 12, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Might be the cause of #16914

  1. with_label_values only call once instead of each time during poll_next.
  2. when metric_level is lower than debug, the metric will not be recorded and there will be no overhead related to this metric at all.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Jun 12, 2024
@kwannoel
Copy link
Contributor

metric_level is lower than debug

How do we set metric_level? Is it done via an env var, similar to RUST_LOG?

@lmatz
Copy link
Contributor Author

lmatz commented Jun 12, 2024

SCR-20240612-ojs

cloud set it by environment variable

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lmatz
Copy link
Contributor Author

lmatz commented Jun 12, 2024

Since it is tested by a nightly pipeline, I will just let it run tonight and see if we can close the issue tomorrow.

@lmatz lmatz enabled auto-merge June 12, 2024 09:55
@lmatz lmatz added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit c9c7064 Jun 12, 2024
28 of 29 checks passed
@lmatz lmatz deleted the lz/fix_merge_metrics branch June 12, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants