-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): rework ci labels used to trigger workflows #17197
Conversation
7cf0839
to
66cab37
Compare
Thanks for work! Does the How about
|
Just took a look at buildkite's conditional expression support. To support this, we need to check for But the conditional expression support is kind of limited. https://buildkite.com/docs/pipelines/conditionals#variable-and-syntax-reference. It supports regex, but not for |
6314aa2
to
c080a25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I mean, taking key: "e2e-test-release"
command: "ci/scripts/cron-e2e-test.sh -p ci-release -m ci-3streaming-2serving-3fe"
if: |
build.pull_request.labels includes "ci/main-cron/run-all"
|| build.pull_request.labels includes "ci/run-e2e-test"
|| build.env("CI_STEPS") =~ /(^|,)e2e-tests?(,|$$)/
depends_on: What do you think? |
Just get to know that there is another condition in pipeline's setting:
Thus it seems inevitable to introduce a |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Closes #17182.
Improvements:
run-selected
is clearer thanskip-ci
.See the developer guide for more info, or the labels in this PR.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.