Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP test old rdkafka #17196

Closed
wants to merge 3 commits into from
Closed

WIP test old rdkafka #17196

wants to merge 3 commits into from

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jun 11, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

reverts to the version before #11232

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: xxchan <[email protected]>
xxchan added 2 commits June 11, 2024 14:58
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
@BugenZhao
Copy link
Member

Just realized that we've observed the regression in #12959 (comment), which was mixed with #13105 and closed without addressing both of the causes.

@fuyufjh
Copy link
Member

fuyufjh commented Jun 12, 2024

Do we confirm the problem is caused by rdkafka? There are other changes such as aws sdk

madsim-rs/madsim@fedb1e3...main

@xxchan
Copy link
Member Author

xxchan commented Jun 12, 2024

You can see in the Cargo.lock, only rdkafka (and madsim-rdkafka) changed.

Copy link
Contributor

This PR has been open for 60 days with no activity.

If it's blocked by code review, feel free to ping a reviewer or ask someone else to review it.

If you think it is still relevant today, and have time to work on it in the near future, you can comment to update the status, or just manually remove the no-pr-activity label.

You can also confidently close this PR to keep our backlog clean. (If no further action taken, the PR will be automatically closed after 7 days. Sorry! 🙏)
Don't worry if you think the PR is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@fuyufjh
Copy link
Member

fuyufjh commented Aug 12, 2024

Any updates on #14815?

@xxchan
Copy link
Member Author

xxchan commented Aug 12, 2024

I think @lmatz is working on bisecting a proper rdkafka version to find where's the regression.

@lmatz
Copy link
Contributor

lmatz commented Aug 28, 2024

I think @lmatz is working on bisecting a proper rdkafka version to find where's the regression.

no, I am not

@xxchan xxchan closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants