Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): limit use of hummock version safe epoch #17161

Merged
merged 6 commits into from
Jun 12, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Jun 6, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As we are supporting partial checkpoint, we will maintain per table safe epoch, and the global safe epoch will be deprecated. In this PR, the scope of the global safe epoch will be narrowed down to the safe epoch of visible tables, and we will avoid using this global safe epoch in our best efforts.

The visibility of safe_epoch field in HummockVersion gets private now. Anyone that wants to access the field should explicitly call visible_table_safe_epoch method.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wenym1 wenym1 requested review from hzxa21, Li0k and zwang28 June 11, 2024 03:51
Copy link
Contributor

@zwang28 zwang28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenym1 wenym1 added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit 3da3d16 Jun 12, 2024
29 of 30 checks passed
@wenym1 wenym1 deleted the yiming/limit-safe-epoch branch June 12, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants