Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): fix cassandra sink error #17148

Merged
merged 3 commits into from
Jun 17, 2024
Merged

fix(test): fix cassandra sink error #17148

merged 3 commits into from
Jun 17, 2024

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Jun 6, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

It seems that it was because Cassandra was not ready and added a timeout before it was resolved

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@hzxa21
Copy link
Collaborator

hzxa21 commented Jun 6, 2024

Can you explain why downgrading Cassandra can fix the error? Does it mean that we only support a specific version of Cassandra?

@xxhZs
Copy link
Contributor Author

xxhZs commented Jun 6, 2024

Can you explain why downgrading Cassandra can fix the error? Does it mean that we only support a specific version of Cassandra?

Currently testing CI, i will provide additional reasons after testing. However, this issue is not related to our compatibility with Cass, but rather to the script we wrote for CI

@xxhZs xxhZs force-pushed the xxh/fix-cassandra-test branch 2 times, most recently from b16c5df to 14234de Compare June 7, 2024 03:35
@xxhZs xxhZs force-pushed the xxh/fix-cassandra-test branch from 14234de to 99f57aa Compare June 7, 2024 05:51
Copy link

gitguardian bot commented Jun 17, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9425213 Triggered Generic Password 7ef8fad ci/scripts/e2e-sink-test.sh View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@wenym1 wenym1 enabled auto-merge June 17, 2024 10:14
@wenym1 wenym1 added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit e4dea80 Jun 17, 2024
29 of 31 checks passed
@wenym1 wenym1 deleted the xxh/fix-cassandra-test branch June 17, 2024 10:38
lmatz pushed a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants