-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): store compaction group id in per table info #17125
Merged
Merged
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
f587d0d
feat(storage): register member table id at commit epoch
wenym1 c802026
fix
wenym1 1216fcf
fix compile
wenym1 ffa06a4
Merge branch 'main' into yiming/register-hummock-table-in-commit
wenym1 c1188df
unregister table id in barrier command
wenym1 c091e59
fix compile
wenym1 5ea467e
feat(storage): support different snapshot for streaming jobs
wenym1 5d291f0
unregister member table id at commit_epoch
wenym1 b84b211
impl apply_version_delta
wenym1 80ee13e
fill backward compatibility snapshot group
wenym1 ad6fa20
Merge branch 'yiming/register-hummock-table-in-commit' into yiming/hu…
wenym1 f1b47b2
register snapshot group in commit epoch
wenym1 4025d64
impl purge
wenym1 0e50f63
fix
wenym1 e0b0697
fix compile
wenym1 a493db6
fix
wenym1 a03260f
Merge branch 'main' into yiming/register-hummock-table-in-commit
wenym1 f89ecd1
Merge branch 'yiming/register-hummock-table-in-commit' into yiming/hu…
wenym1 dbdd475
fix comment
wenym1 8318f5f
Merge branch 'yiming/register-hummock-table-in-commit' into yiming/hu…
wenym1 beb78a5
rename
wenym1 af38f68
fix compile
wenym1 778080b
impl system table
wenym1 5860e14
no extra info in create command
wenym1 f4dd843
unregister table id separately
wenym1 f934ba8
Merge branch 'yiming/register-hummock-table-in-commit' into yiming/hu…
wenym1 a8bf79d
refine
wenym1 e94774c
Merge branch 'main' into yiming/register-hummock-table-in-commit
wenym1 7cdca7b
Merge branch 'yiming/register-hummock-table-in-commit' into yiming/hu…
wenym1 2a41e01
add more panic log
wenym1 ef3af37
Merge branch 'main' into yiming/hummock-snapshot-group
wenym1 6dbaebb
add prev id assertion
wenym1 b980553
Merge branch 'main' into yiming/hummock-snapshot-group
wenym1 8000937
fix
wenym1 d53a32d
rename
wenym1 fd993d3
Merge branch 'main' into yiming/hummock-snapshot-group
wenym1 fb87284
Merge branch 'main' into yiming/hummock-snapshot-group
wenym1 28c50b5
Merge branch 'main' into yiming/hummock-snapshot-group
wenym1 307340d
Merge commit 'dac892e9777d4c249da3ae81fdf7b2d3d1218ae7' into yiming/h…
wenym1 11e7198
Merge branch 'main' into yiming/hummock-snapshot-group
wenym1 e57ed35
Merge branch 'main' into yiming/hummock-snapshot-group
wenym1 37df492
per table snapshot
wenym1 07d6d5d
feat(storage): store compaction group id in per table info
wenym1 ed2b4cc
extract state table info struct
wenym1 8735ebb
fmt
wenym1 0f31e14
Merge branch 'yiming/hummock-snapshot-group' into yiming/compaction-g…
wenym1 07ff5e2
extract rebuild index
wenym1 fc60078
Merge branch 'main' into yiming/hummock-snapshot-group
wenym1 7c97d95
remove log
wenym1 b717e7c
fix compile
wenym1 c05e376
Merge branch 'main' into yiming/hummock-snapshot-group
wenym1 3ad89de
Merge branch 'yiming/hummock-snapshot-group' into yiming/compaction-g…
wenym1 8030edc
fix test
wenym1 a98bf38
Merge branch 'main' into yiming/compaction-group-in-table-info
wenym1 ef81602
Merge branch 'main' into yiming/compaction-group-in-table-info
wenym1 0ffc3ad
remove unnecessary logic
wenym1 0f55e99
Merge branch 'main' into yiming/compaction-group-in-table-info
wenym1 9e53e9a
fix comment
wenym1 ae1b046
Merge branch 'main' into yiming/compaction-group-in-table-info
wenym1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it mean that we can completely deprecate
GroupMetaChange
inGroupDelta
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because we won't update the
member_table_ids
anymore.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add
deprecated
in L107 then?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
deprecated
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we miss
[deprecated = true]
in L107 forGroupMetaChange
.