Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batch): support spill hash join #17122

Merged
merged 20 commits into from
Jun 5, 2024
Merged

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Jun 5, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Tracking issue Tracking: batch query memory control and spill #16615
  • Support spill hash join based on RFC RFC: Spill Hash Join rfcs#91
  • To spill a hash join, we can use the same idea from the spill hash aggregation RFC, i.e. partition inputs of hash join to reduce the hash table size needed to be process within a hash join. Because hash join has two inputs, we need to use a same hash function to hash both inputs into partition pairs. Within a partiton, we will get a probe side input spill file and a build side input spill file. The size of the partition is expected to the much smaller than the original input size, so we can run a hash join against these partitions one by one and recursively if necessary.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

  • Support spill hash join to leverage the disk to avoid OOM.

@chenzl25 chenzl25 added the user-facing-changes Contains changes that are visible to users label Jun 5, 2024
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenzl25 chenzl25 enabled auto-merge June 5, 2024 09:29
@chenzl25 chenzl25 added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit 030f2fa Jun 5, 2024
28 of 29 checks passed
@chenzl25 chenzl25 deleted the dylan/support_spill_hash_join branch June 5, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants