Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expr): evaluate scalar expr non-strictly in streaming #17084

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

wangrunji0408
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #12474

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wangrunji0408 wangrunji0408 requested review from BugenZhao and xxchan June 4, 2024 05:50
@github-actions github-actions bot added the type/fix Bug fix label Jun 4, 2024
@wangrunji0408 wangrunji0408 force-pushed the wrj/fix-project-set branch from 6152a42 to b877e18 Compare June 4, 2024 05:51
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/stream/src/executor/project_set.rs Outdated Show resolved Hide resolved
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
@wangrunji0408 wangrunji0408 enabled auto-merge June 4, 2024 07:05
@wangrunji0408
Copy link
Contributor Author

wangrunji0408 commented Jun 4, 2024

@BugenZhao any ideas on how to rewrite e2e_test/error_ui/simple/recovery.slt? one option is to switch to another bug #11915 for now. 🤪

@BugenZhao
Copy link
Member

@BugenZhao any ideas on how to rewrite e2e_test/error_ui/simple/recovery.slt? one option is to switch to another bug #11915 for now. 🤪

Sure. Let's use that as a workaround until we find a good approach to reliably trigger a meaningful failure.

@wangrunji0408
Copy link
Contributor Author

What about introducing a test-only function rw_panic()?

@BugenZhao
Copy link
Member

What about introducing a test-only function rw_panic()?

We already have a RECOVERY command to tigger a recovery on meta, and I've also attempted to add a command to trigger a failure on compute node (#16397 (comment)).

However, as this test also covers the root cause identification (#16431), I'm afraid whether a manually-triggered failure is general enough. 🤔

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit bd61cb1 Jun 4, 2024
28 of 29 checks passed
@wangrunji0408 wangrunji0408 deleted the wrj/fix-project-set branch June 4, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: scalar expressions in StreamProjectSet are not evaluated non-strictly
2 participants