-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(expr): evaluate scalar expr non-strictly in streaming #17084
Conversation
Signed-off-by: Runji Wang <[email protected]>
6152a42
to
b877e18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
@BugenZhao any ideas on how to rewrite |
Sure. Let's use that as a workaround until we find a good approach to reliably trigger a meaningful failure. |
What about introducing a test-only function |
Signed-off-by: Runji Wang <[email protected]>
We already have a However, as this test also covers the root cause identification (#16431), I'm afraid whether a manually-triggered failure is general enough. 🤔 |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix #12474
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.