Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(over window): improve error message for empty partition by #17071

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Jun 3, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As simple as title, fixes #16924.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@stdrc stdrc requested a review from lmatz June 3, 2024 09:53
@stdrc stdrc requested review from BugenZhao and xxchan June 3, 2024 09:54
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc enabled auto-merge June 4, 2024 04:00
@stdrc stdrc added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 9be340d Jun 4, 2024
28 of 29 checks passed
@stdrc stdrc deleted the rc/partition-by-1-advice branch June 4, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer advice when Window function with empty PARTITION BY is not supported yet
3 participants