Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore varchar with length #17049

Closed
wants to merge 5 commits into from
Closed

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented May 31, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Part of #17037.

Preview:

dev=> create table t1 (c1 varchar, c2 varchar(10));
NOTICE:  CHARACTER VARYING with length is not supported. The length is ignored.
CREATE_TABLE

dev=> create table t2 (c1 varchar, c2 varchar(10), c3 varchar(10000));
NOTICE:  CHARACTER VARYING with length is not supported. The length is ignored.
NOTICE:  CHARACTER VARYING with length is not supported. The length is ignored.
CREATE_TABLE

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This LGTM, but it may still not be able to solve my intial problem.

Signed-off-by: tabVersion <[email protected]>
@fuyufjh fuyufjh closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants