Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): impl report to scarf #17046

Merged
merged 5 commits into from
Jun 4, 2024
Merged

feat(telemetry): impl report to scarf #17046

merged 5 commits into from
Jun 4, 2024

Conversation

tabVersion
Copy link
Contributor

@tabVersion tabVersion commented May 31, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

integrate with Scarf to see who is using RW

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: tabVersion <[email protected]>
@tabVersion tabVersion requested review from arkbriar and fuyufjh May 31, 2024 09:06
@alicelyy alicelyy marked this pull request as ready for review May 31, 2024 15:56
@tabVersion
Copy link
Contributor Author

@huangjw806 please review the pr and check if there is any leftover in the config file to make the meta node's ENV TELEMETRY_CLUSTER_TYPE=test in CI and other tests, to avoid reports from our hosted services.

@tabVersion tabVersion requested a review from huangjw806 June 2, 2024 15:24
Copy link
Contributor

@huangjw806 huangjw806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
In addition to the CI test cluster, I will add this configuration for the k8s test cluster.

Copy link
Contributor

@arkbriar arkbriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The PR is rather a legal problem than a code problem. I would suggest we make it clear before merging.

@tabVersion
Copy link
Contributor Author

@mrayees has confirmed the legal thing. Merging now.

@tabVersion tabVersion added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit c42fca3 Jun 4, 2024
31 of 32 checks passed
@tabVersion tabVersion deleted the tab/scarf branch June 4, 2024 03:21
tabVersion added a commit that referenced this pull request Jun 5, 2024
Signed-off-by: tabVersion <[email protected]>
Co-authored-by: Alice lol <[email protected]>
Co-authored-by: alicelyu <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jun 5, 2024
Signed-off-by: tabVersion <[email protected]>
Co-authored-by: Alice lol <[email protected]>
Co-authored-by: alicelyu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants