Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expr): implement pg_get_keywords() and pg_keywords #17033

Merged
merged 4 commits into from
May 31, 2024

Conversation

wangrunji0408
Copy link
Contributor

Signed-off-by: Runji Wang [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

resolve #17023

This PR implements pg_get_keywords() function and pg_keywords system catalog.
However, the implementation is not entirely correct. There are many rows in the output that have a different category than postgres. I don't fully understand how to map our reserved keyword tables to the category defined by PG. But if it's just to resolve the problem mentioned in #17023, maybe non-empty output is enough.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

Support pg_get_keywords() function and pg_keywords system catalog.

@wangrunji0408 wangrunji0408 requested a review from a team as a code owner May 30, 2024 15:45
Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I tested locally and it worked.

@wangrunji0408 wangrunji0408 added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit c560d2d May 31, 2024
31 of 32 checks passed
@wangrunji0408 wangrunji0408 deleted the wrj/pg_get_keywords branch May 31, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement pg_get_keywords() function
4 participants