Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: minor refactor on avro #17024

Merged
merged 2 commits into from
May 30, 2024
Merged

refactor: minor refactor on avro #17024

merged 2 commits into from
May 30, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented May 30, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

xxchan commented May 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xxchan and the rest of your teammates on Graphite Graphite

@xxchan xxchan changed the title minor refactor on avro refactor: minor refactor on avro May 30, 2024
@xxchan xxchan marked this pull request as ready for review May 30, 2024 08:36
@xxchan xxchan enabled auto-merge May 30, 2024 08:38
@xxchan xxchan added this pull request to the merge queue May 30, 2024
Copy link
Member Author

xxchan commented May 30, 2024

Merge activity

  • May 30, 5:42 PM GMT+8: Graphite failed to merge this pull request due to This repository has GitHub's merge queue enabled, which is currently incompatible with Graphite. Try your merge again, or report a bug if you see this consistently.

Merged via the queue into main with commit 0c8b036 May 30, 2024
29 of 30 checks passed
@xxchan xxchan deleted the 05-30-minor_refactor_on_avro branch May 30, 2024 10:10
BugenZhao pushed a commit that referenced this pull request Jun 12, 2024
Signed-off-by: xxchan <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants