refactor(parser): eliminate the gap between parser v1 and v2 #17019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
wangrunji0408
force-pushed
the
wrj/parser-v2
branch
from
574da01 to
5c9c66e
Compare
Signed-off-by: Runji Wang <[email protected]>
TennyZhuang
approved these changes
May 30, 2024
Signed-off-by: TennyZhuang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: TennyZhuang <[email protected]>
BugenZhao
reviewed
May 31, 2024
| @@ -499,12 +471,10 @@ impl Parser { | |||
| /// Tries to parses a wildcard expression without any parentheses. | |||
| /// | |||
| /// If wildcard is not found, go back to `index` and parse an expression. | |||
There was a problem hiding this comment.
Should also update the comments? Also apply to others.
| alt(( | ||
| preceded( | ||
| (Keyword::SYSTEM_TIME, Keyword::AS, Keyword::OF), | ||
| alt(( |
There was a problem hiding this comment.
I think so. We also need more tests to cover these cases.
Comment on lines
+236
to
+237
| Parser::parse_object_name | ||
| .parse(parser) |
There was a problem hiding this comment.
This does not look that intuitive. 🤣 I guess that's because...
- we make combinator a method instead of a bare function
- the name starts with
parse_
There was a problem hiding this comment.
Yes. Eventually we should make these methods bare functions without the parse_ prefix.
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Runji Wang [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR merges
TokenStreamWrapperwithParserand makes all parser methods returnPResult, so that they can be used with the combinators inwinnow.To improve the accuracy of cursor in error context, this PR also:
With this PR, we can migrate the parser from v1 to v2 more smoothly.
Checklist
./risedev check(or alias,./risedev c)Documentation