refactor(connector): remove JsonParser from production code
#17016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugenZhao
commented
May 30, 2024
xxchan
approved these changes
May 30, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @BugenZhao and the rest of your teammates on |
stdrc
approved these changes
May 30, 2024
There was a problem hiding this comment.
Do you have any suggestions?
There was a problem hiding this comment.
IDK, json_access_builder? bytes_parser.rs also doesn't have any BytesParser.
tabVersion
reviewed
May 30, 2024
There was a problem hiding this comment.
seems meaningless since we've removed json parser
There was a problem hiding this comment.
Still meaningful until we resolve #14815. 🥺
BugenZhao
force-pushed
the
bz/remove-json-parser
branch
from
bb6d16b to
1f2d16e
Compare
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/remove-json-parser
branch
from
1f2d16e to
7aace1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bugen Zhao [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Following up #16996, this PR removes
JsonParserfrom production code. Close #16968.json_parser.rsto useByteStreamSourceParserImplto create a (plain) parser to cover the real path.JsonParserto the benchmark ofjson_vs_plain_parser.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.