Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update README.md to notice the user about RisingWave's usage of Scarf #17012

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

@alicelyy alicelyy changed the title Update README.md to notice the user about RisingWave's usage of Scarf doc: update README.md to notice the user about RisingWave's usage of Scarf May 29, 2024
@alicelyy alicelyy marked this pull request as ready for review June 7, 2024 20:48
@arkbriar arkbriar requested review from tabVersion and hengm3467 June 10, 2024 02:46
@xiangjinwu
Copy link
Contributor

xiangjinwu commented Jun 11, 2024

There is a Notes on telemetry section below already.

RisingWave collects anonymous usage statistics to better understand how the community is using RisingWave. The sole intention of this exercise is to help improve the product. Users may opt out easily at any time. Please refer to the user documentation for more details.

@alicelyy
Copy link
Contributor Author

There is a Notes on telemetry section below already.

RisingWave collects anonymous usage statistics to better understand how the community is using RisingWave. The sole intention of this exercise is to help improve the product. Users may opt out easily at any time. Please refer to the user documentation for more details.

Telemetry is not our only usage of Scarf. We also track user IP from docker download link (pending CNAME change from our network infra provider) as well as various website pages visits. For this reason I think it may be more appropriate to put the notice at a higher level location.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
alicelyy and others added 3 commits June 11, 2024 01:16
Co-authored-by: hengm3467 <[email protected]>
The usage of Scarf is not really configurable for the most part
@alicelyy alicelyy added this pull request to the merge queue Jun 11, 2024
Merged via the queue into risingwavelabs:main with commit 531aa8b Jun 11, 2024
9 checks passed
@alicelyy alicelyy deleted the patch-1 branch June 11, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants