Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log-store): rebuild log store iter when exists for a timeout #17009

Merged
merged 2 commits into from
May 30, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented May 29, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolve #16984

In log store, we may have iters that consume a large number of historical data, which may exist for long time. The iter will keep pinning a hummock version, and causes stale sst unable to be reclaimed.

In this PR, we set a fixed 10 minutes timeout for the log store iter. On timeout, the iter will be rebuilt starting from the latest offset, so that we can iter on the same data from the original progress but by with a newer version. In this way we can avoid pinning the hummock version for too long time.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@zwang28 zwang28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MrCroxx MrCroxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenym1 wenym1 changed the title feat(log-store): rebuild log store iter when exists for a timeout fix(log-store): rebuild log store iter when exists for a timeout May 30, 2024
@github-actions github-actions bot added type/fix Bug fix and removed type/feature labels May 30, 2024
@wenym1 wenym1 enabled auto-merge May 30, 2024 05:44
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenym1 wenym1 added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit 4e64389 May 30, 2024
27 of 28 checks passed
@wenym1 wenym1 deleted the yiming/rebuild-log-store-iter-with-timeout branch May 30, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hummock version unpin delay due to log store lags
4 participants