feat(storage): avoid uploader depending on seal_epoch #16985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzxa21
reviewed
Jun 3, 2024
Comment on lines
995
to
1002
| /// Poll the success of the oldest spilled task of unsealed data. Return `Poll::Ready(None)` if | ||
| /// there is no spilling task. | ||
| fn poll_unsealed_spill_task( | ||
| &mut self, | ||
| cx: &mut Context<'_>, | ||
| ) -> Poll<Option<StagingSstableInfo>> { | ||
| // iterator from older epoch to new epoch so that the spill task are finished in epoch order | ||
| for unsealed_data in self.unsealed_data.values_mut() { | ||
| for unsealed_data in self.unsync_data.epoch_data.values_mut() { |
There was a problem hiding this comment.
I think the term unseal/sealed/sync are used with different meanings in different parts of the codes after this PR. For example, sealed data in LocalInstanceUnsyncData is considered unsealed in the context of HummockUploader. Can we make it less confusing by having a clear definition of sync and sealed? Some ideas:
unsealed: per instance concept. Data is unsealed beforelocal_seal_epochsealed: per instance concept. Data is sealed afterlocal_seal_epochspill: per epoch concept. Data is spilled ifmay_spilltriggers.sync: per epoch conecpt. Data is synced aftersync.
unsealed, sealed and spill data are all considered unsync.
Following this ideas, we can:
- rename
poll_unsealed_spill_tasktopoll_unsync_spill_task - remove
SealedDatastruct and return the correspondingepoch_dataonunsync_data.sync
There was a problem hiding this comment.
Indeed. I have removed the concept of sealed and unsealed in global uploader. The concept is only in LocalInstanceUnsyncData.
github-actions
bot
added
ci/run-e2e-single-node-tests
and removed
ci/run-e2e-single-node-tests
labels
wenym1
force-pushed
the
yiming/deprecate-global-seal-epoch
branch
from
be45d98 to
f5e3455
Compare
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.