feat(optimizer): improve scalar subqueries optimization time #16966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuyufjh
reviewed
May 28, 2024
Comment on lines
313
to
339
| if let Some(join) = plan.as_logical_join() { | ||
| Self::rewrite_join( | ||
| join, | ||
| left_idxs, | ||
| offset, | ||
| index_mapping, | ||
| data_types, | ||
| index, | ||
| ) | ||
| } else if let Some(apply) = plan.as_logical_apply() { | ||
| Self::rewrite_apply( | ||
| apply, | ||
| left_idxs, | ||
| offset, | ||
| index_mapping, | ||
| data_types, | ||
| index, | ||
| ) | ||
| } else if let Some(scan) = plan.as_logical_scan() { | ||
| Self::rewrite_scan( | ||
| scan, | ||
| left_idxs, | ||
| offset, | ||
| index_mapping, | ||
| data_types, | ||
| index, | ||
| ) |
There was a problem hiding this comment.
Are these lines duplicated with the lambda rewrite?
There was a problem hiding this comment.
Let me refactor that. Thanks for pointing it out.
fuyufjh
approved these changes
May 28, 2024
| └─BatchExchange { order: [], dist: HashShard(t.arr) } | ||
| └─BatchScan { table: t, columns: [t.arr], distribution: SomeShard } | ||
| └─BatchExchange { order: [], dist: HashShard(t.arr) } | ||
| └─BatchScan { table: t, columns: [t.arr], distribution: SomeShard } |
There was a problem hiding this comment.
Curious why this plan gets improved?
There was a problem hiding this comment.
Because the initial logical plan of this case is:
LogicalProject { exprs: [t.x, t.arr, unnest, ordinality, unnest, ordinality] }
└─LogicalApply { type: Inner, on: true, correlated_id: 1 }
├─LogicalApply { type: Inner, on: true, correlated_id: 2 }
│ ├─LogicalScan { table: t, columns: [x, arr, _row_id] }
│ └─LogicalTableFunction { table_function: Unnest(CorrelatedInputRef { index: 1, correlated_id: 2 }) }
└─LogicalTableFunction { table_function: Unnest(CorrelatedInputRef { index: 1, correlated_id: 1 }) }It is the same shape as the multi scalar subqueries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Apply. As a result, it is hard to find the original domain for the upperApplyoperator. In this PR, we try to translate theApplyin a top-down order and simplify the domain by extracting the domain from the apply input. In this way, optimization time could linearly increase as the number of scalar subqueries grows.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.