feat(udf): add metric of UDF memory usage #16922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
…rectly Signed-off-by: Runji Wang <[email protected]>
xxchan
reviewed
May 26, 2024
xxchan
reviewed
May 26, 2024
Comment on lines
+355
to
+357
| // generate an unique id for each instance | ||
| static NEXT_INSTANCE_ID: AtomicU64 = AtomicU64::new(0); | ||
| let instance_id = NEXT_INSTANCE_ID.fetch_add(1, Ordering::Relaxed).to_string(); |
There was a problem hiding this comment.
The memory usage is a gauge. So we need to distinguish each instance's metric by a different label, otherwise the value will be overridden rather than accumulated.
Co-authored-by: xxchan <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
xxchan
approved these changes
May 27, 2024
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
…mory-usage Signed-off-by: Runji Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Runji Wang [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR adds a metric of UDF memory usage. Currently only embedded JS UDF supports that, others will always show 0. This PR also replaces UDF metrics by our label-guarded version.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.