chore(catalog): avoid rw_catalog in pg_tables #16915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Avoid the
rw_catalog.rw_*
tables in thepg_catalog.pg_tables
.The reason for this is that metabase will list all the normal tables by filtering out
pg_catalog.pg_*
andinformation schema.*
from the result ofpg_catalog.pg_tables
and check the privileges of these tables usinghas_table_privileges
.has_table_privilege
requires the table'soid
to check privileges. Some ofrw_catalog.rw_
have nooid
, as a result, metabase will stuck atsyncing tables
stage due to the failure ofhas_table_privilege
check. So to avoid this, I removed all therw_catalog.rw_*
tables frompg_catalog.pg_tables
's result.It makes sense because when a user use
pg_catalog.pg_tables
, he wants to see the result just like postgres. Hiding tables underrw_catalog
makes the experience aligned. Or if you have any better idea, please feel free to comment.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.