Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to opendal 0.46 and pass Vec<Bytes> on writer.write #16886

Closed
wants to merge 16 commits into from

Conversation

hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented May 22, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@hzxa21 hzxa21 requested a review from wcy-fdu May 22, 2024 07:20
Copy link
Contributor

@wcy-fdu wcy-fdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM! Wait for more testing result.

Comment on lines 31 to 41
opendal = { version = "0.46", features = [
"services-azblob",
"services-fs",
"services-gcs",
"services-memory",
"services-obs",
"services-oss",
"services-s3",
"services-webhdfs",
"services-azfile",
] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So after OpenDAL 0.46, if we want to enable hdfs, we need to manually add the hdfs feature. So how about add it here and comment it out?

Suggested change
opendal = { version = "0.46", features = [
"services-azblob",
"services-fs",
"services-gcs",
"services-memory",
"services-obs",
"services-oss",
"services-s3",
"services-webhdfs",
"services-azfile",
] }
opendal = { version = "0.46", features = [
"services-azblob",
"services-fs",
"services-gcs",
"services-memory",
"services-obs",
"services-oss",
"services-s3",
"services-webhdfs",
"services-azfile",
# "services-hdfs",
] }

@hzxa21 hzxa21 force-pushed the patrick/bump-opendal-46.pr branch from 86cd6e8 to c0add2c Compare June 4, 2024 14:12
@hzxa21
Copy link
Collaborator Author

hzxa21 commented Jun 11, 2024

Move to #17198

@hzxa21 hzxa21 closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants