-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to opendal 0.46 and pass Vec<Bytes> on writer.write #16886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM! Wait for more testing result.
src/object_store/Cargo.toml
Outdated
opendal = { version = "0.46", features = [ | ||
"services-azblob", | ||
"services-fs", | ||
"services-gcs", | ||
"services-memory", | ||
"services-obs", | ||
"services-oss", | ||
"services-s3", | ||
"services-webhdfs", | ||
"services-azfile", | ||
] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So after OpenDAL 0.46, if we want to enable hdfs, we need to manually add the hdfs feature. So how about add it here and comment it out?
opendal = { version = "0.46", features = [ | |
"services-azblob", | |
"services-fs", | |
"services-gcs", | |
"services-memory", | |
"services-obs", | |
"services-oss", | |
"services-s3", | |
"services-webhdfs", | |
"services-azfile", | |
] } | |
opendal = { version = "0.46", features = [ | |
"services-azblob", | |
"services-fs", | |
"services-gcs", | |
"services-memory", | |
"services-obs", | |
"services-oss", | |
"services-s3", | |
"services-webhdfs", | |
"services-azfile", | |
# "services-hdfs", | |
] } |
86cd6e8
to
c0add2c
Compare
This reverts commit 065e57d.
Move to #17198 |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.