fix(stream): arrangement backfill should use dist key instead of pk to derive vnode #16815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The error seen will be (See the failing test here: https://buildkite.com/risingwavelabs/pull-request/builds/49863#018f9186-a50d-4f80-91d9-4ba0a30ca007):
The fix is to just use
dist_key
instead ofpk
to derive the vnode when handling chunks coming from upstream. This is done with the state table'scompute_vnode_by_pk
interface. Under the hood, it will use thedist_key_indices_in_pk
to extract the dist key from pk, and construct the vnode.This will impact newly created MVs, when their dist_keys do not match their PKs.
The workaround is to
set streaming_use_arrangement_backfill=false
.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.