Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing specified meta backend for backwards compat test config (#16797) #16808

Merged
merged 1 commit into from
May 17, 2024
+39 −5
Merged

fix: missing specified meta backend for backwards compat test config (#16797) #16808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions backwards-compat-tests/scripts/run_local.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,11 @@ trap on_exit EXIT
source backwards-compat-tests/scripts/utils.sh

configure_rw() {
echo "--- Setting up cluster config"
cat <<EOF > risedev-profiles.user.yml
VERSION="$1"

echo "--- Setting up cluster config"
if version_le "$VERSION" "1.9.0"; then
cat <<EOF > risedev-profiles.user.yml
full-without-monitoring:
steps:
- use: minio
Expand All @@ -28,6 +31,23 @@ full-without-monitoring:
address: message_queue
port: 29092
EOF
else
cat <<EOF > risedev-profiles.user.yml
full-without-monitoring:
steps:
- use: minio
- use: etcd
- use: meta-node
meta-backend: etcd
- use: compute-node
- use: frontend
- use: compactor
- use: kafka
user-managed: true
address: message_queue
port: 29092
EOF
fi

cat <<EOF > risedev-components.user.env
RISEDEV_CONFIGURED=false
Expand Down Expand Up @@ -58,11 +78,11 @@ main() {
set -euo pipefail
get_rw_versions
setup_old_cluster
configure_rw
configure_rw "$OLD_VERSION"
seed_old_cluster "$OLD_VERSION"

setup_new_cluster
configure_rw
configure_rw "99.99.99"
validate_new_cluster "$NEW_VERSION"
}

Expand Down
16 changes: 15 additions & 1 deletion ci/scripts/backwards-compat-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ VERSION="$1"
ENABLE_BUILD="$2"

echo "--- Setting up cluster config"
cat <<EOF > risedev-profiles.user.yml
if version_le "$VERSION" "1.9.0"; then
cat <<EOF > risedev-profiles.user.yml
full-without-monitoring:
steps:
- use: minio
Expand All @@ -51,6 +52,19 @@ full-without-monitoring:
- use: frontend
- use: compactor
EOF
else
cat <<EOF > risedev-profiles.user.yml
full-without-monitoring:
steps:
- use: minio
- use: etcd
- use: meta-node
meta-backend: etcd
- use: compute-node
- use: frontend
- use: compactor
EOF
fi

cat <<EOF > risedev-components.user.env
RISEDEV_CONFIGURED=true
Expand Down
Loading