Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stream): add debug logs for join key with high amplification #16799

Merged
merged 3 commits into from
May 17, 2024
Merged

feat(stream): add debug logs for join key with high amplification #16799

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b01f79
add logs
kwannoel May 17, 2024
ace0230
bump e2e test timeout
kwannoel May 17, 2024
977d15d
deserialize join key directly
kwannoel May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/stream/src/executor/hash_join.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,6 +829,17 @@ impl<K: HashKey, S: StateStore, const T: JoinTypePrimitive> HashJoinExecutor<K,

if let Some(rows) = &matched_rows {
join_matched_join_keys.observe(rows.len() as _);
if rows.len() > 10000 {
kwannoel marked this conversation as resolved.
Show resolved Hide resolved
tracing::debug!(target: "hash_join_amplification",
matched_rows_len = rows.len(),
update_table_id = side_update.ht.table_id(),
match_table_id = side_match.ht.table_id(),
join_key = ?key,
kwannoel marked this conversation as resolved.
Show resolved Hide resolved
actor_id = ctx.id,
fragment_id = ctx.fragment_id,
"large rows matched for join key"
);
}
} else {
join_matched_join_keys.observe(0.0)
}
Expand Down
Loading