Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): revert bump object_store_read_attempt_timeout_ms from 8s to 16s" #16789

Merged
merged 1 commit into from
May 16, 2024
Merged

chore(storage): revert bump object_store_read_attempt_timeout_ms from 8s to 16s" #16789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ steps:
config: ci/docker-compose.yml
mount-buildkite-agent: true
- ./ci/plugins/upload-failure-logs
timeout_in_minutes: 23
timeout_in_minutes: 21
retry: *auto-retry

- label: "end-to-end test (parallel)"
Expand Down
6 changes: 3 additions & 3 deletions src/common/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1751,7 +1751,7 @@ pub mod default {
pub mod object_store_config {
const DEFAULT_REQ_BACKOFF_INTERVAL_MS: u64 = 1000; // 1s
const DEFAULT_REQ_BACKOFF_MAX_DELAY_MS: u64 = 10 * 1000; // 10s
const DEFAULT_REQ_MAX_RETRY_ATTEMPTS: usize = 5;
const DEFAULT_REQ_MAX_RETRY_ATTEMPTS: usize = 3;

pub fn object_store_set_atomic_write_dir() -> bool {
false
Expand Down Expand Up @@ -1779,7 +1779,7 @@ pub mod default {

// init + upload_part + finish
pub fn object_store_streaming_upload_attempt_timeout_ms() -> u64 {
10 * 1000 // 10s
5 * 1000 // 5s
}

pub fn object_store_streaming_upload_retry_attempts() -> usize {
Expand All @@ -1788,7 +1788,7 @@ pub mod default {

// tips: depend on block_size
pub fn object_store_read_attempt_timeout_ms() -> u64 {
16 * 1000 // 16s
8 * 1000 // 8s
}

pub fn object_store_read_retry_attempts() -> usize {
Expand Down
20 changes: 10 additions & 10 deletions src/config/example.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,21 +192,21 @@ req_backoff_interval_ms = 1000
req_backoff_max_delay_ms = 10000
req_backoff_factor = 2
upload_attempt_timeout_ms = 8000
upload_retry_attempts = 5
streaming_upload_attempt_timeout_ms = 10000
streaming_upload_retry_attempts = 5
read_attempt_timeout_ms = 16000
read_retry_attempts = 5
upload_retry_attempts = 3
streaming_upload_attempt_timeout_ms = 5000
streaming_upload_retry_attempts = 3
read_attempt_timeout_ms = 8000
read_retry_attempts = 3
streaming_read_attempt_timeout_ms = 3000
streaming_read_retry_attempts = 5
streaming_read_retry_attempts = 3
metadata_attempt_timeout_ms = 60000
metadata_retry_attempts = 5
metadata_retry_attempts = 3
delete_attempt_timeout_ms = 5000
delete_retry_attempts = 5
delete_retry_attempts = 3
delete_objects_attempt_timeout_ms = 5000
delete_objects_retry_attempts = 5
delete_objects_retry_attempts = 3
list_attempt_timeout_ms = 600000
list_retry_attempts = 5
list_retry_attempts = 3

[storage.object_store.s3]
object_store_keepalive_ms = 600000
Expand Down
Loading