Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused r#type field in GooglePubSubConfig #16785

Merged
merged 4 commits into from
May 21, 2024

Conversation

jetjinser
Copy link
Contributor

@jetjinser jetjinser commented May 16, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The option type is not used in code but needs to be provided in create sink sql and should be remove.

link #16363.

Checklist

  • I have written necessary rustdoc comments
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

docs pr thats need to update: https://github.com/risingwavelabs/risingwave-docs/pull/2177

@jetjinser jetjinser added the user-facing-changes Contains changes that are visible to users label May 16, 2024
@github-actions github-actions bot added the type/fix Bug fix label May 16, 2024
@tabVersion
Copy link
Contributor

Previously we used the type to express the sink's behavior and now we prefer the format <format name> to express the same meaning. I think it is safe to remove. cc @xiangjinwu

@neverchanje
Copy link
Contributor

neverchanje commented May 17, 2024

For backward compatibility, I would prefer setting this field as Option<String> instead. But if there's no validation rule on this field, just removing it would be better.

BTW, pls remember to rerun ./risedev generate-with-options.

@neverchanje neverchanje enabled auto-merge May 20, 2024 11:49
@neverchanje neverchanje added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 21, 2024
@tabVersion
Copy link
Contributor

a random fault, enqueue again

@tabVersion tabVersion added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 21, 2024
@tabVersion tabVersion enabled auto-merge May 21, 2024 12:21
@tabVersion tabVersion added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 18a0524 May 21, 2024
29 checks passed
@tabVersion tabVersion deleted the jinser/unused-config-pubsub branch May 21, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change type/fix Bug fix user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants