fix(jdbc-sink): fix primary key bindings for the DELETE statement #16770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikeW
added
ci/run-build
ci/skip-ci
ci/run-build-other
ci/run-e2e-source-tests
and removed
type/fix
StrikeW
force-pushed
the
siyuan/fix-jdbc-sink
branch
from
67f8778 to
e22b358
Compare
lmatz
approved these changes
May 15, 2024
|
Does it solve both problems in #16739? |
|
Not yet, still debugging, I think it is very close. |
StrikeW
commented
May 15, 2024
| int pkIdx = pkIndices[i]; | ||
| Object pkField = row.get(pkIdx); | ||
| switch (columnDescs.get(pkIdx).getDataType().getTypeName()) { | ||
| // remove the milliseconds part from the timestamp/timestamptz |
There was a problem hiding this comment.
@xiangjinwu please review this part, thanks.
StrikeW
force-pushed
the
siyuan/fix-jdbc-sink
branch
from
e0ad349 to
b0a2292
Compare
xiangjinwu
reviewed
May 16, 2024
Comment on lines
133
to
142
| case TIMESTAMP: | ||
| LocalDateTime ldt = (LocalDateTime) pkField; | ||
| pkField = | ||
| LocalDateTime.ofEpochSecond( | ||
| ldt.toEpochSecond(ZoneOffset.UTC), 0, ZoneOffset.UTC); | ||
| break; | ||
| case TIMESTAMPTZ: | ||
| OffsetDateTime odt = (OffsetDateTime) pkField; | ||
| pkField = LocalDateTime.ofEpochSecond(odt.toEpochSecond(), 0, ZoneOffset.UTC); | ||
| break; |
There was a problem hiding this comment.
- Both
LocalDateTimeandOffsetDateTimehave a methodwithNanowhich floor to whole seconds. Shorter than current implementation. - It seems
TIMESTAMPTZbranch getsOffsetDateTimeout but putsLocalDateTime. Is it intended or accidental? - Could you elaborate why it is necessary to remove the subsecond part? Maybe it only works when the MySQL table is declared with
DATETIMEandTIMESTAMP, but would fail withDATETIME(6)orTIMESTAMP(6). Specially, PostgreSQL (and RisingWave) default precision is 6 (i.e.timestamptzis short fortimestamptz(6)) while MySQL default precision is 0 (i.e.datetimeis short fordatetime(0)).- This may imply that we need to convert from 6 to whatever precision defined in downstream MySQL. (demo) Are we able to get that info from the downstream column?
There was a problem hiding this comment.
It seems TIMESTAMPTZ branch gets OffsetDateTime out but puts LocalDateTime. Is it intended or accidental?
Intended. since downstream timestamp doesn't store timezone, so I convert to LocalDateTime
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 16, 2024
…6770) (#16775) Co-authored-by: StrikeW <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title.
close: #16739
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.