Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): support fetch n from subscription cursor #16764

Merged
merged 4 commits into from
May 30, 2024
Merged

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented May 15, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

In this pr

  1. fix alter table, but cursor table schema dont change
  2. support fetch n from cursor
  3. fix fetch cursor's columns name(table_name.column_name => column_name)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxhZs xxhZs changed the title feat(frontend): support fetch n from cursor feat(frontend): support fetch n from subscription cursor May 15, 2024
@xxhZs xxhZs requested a review from hzxa21 May 15, 2024 06:50
src/frontend/src/session/cursor_manager.rs Outdated Show resolved Hide resolved
src/frontend/src/session/cursor_manager.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/frontend/src/session/cursor_manager.rs Outdated Show resolved Hide resolved
src/frontend/src/session/cursor_manager.rs Show resolved Hide resolved
@xxhZs xxhZs enabled auto-merge May 30, 2024 07:39
@xxhZs xxhZs added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit 4bef086 May 30, 2024
28 of 29 checks passed
@xxhZs xxhZs deleted the xxh/add-fetch-num branch May 30, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants